Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: Does not allow abortion with ExitCode::Ok #255

Closed
jennijuju opened this issue Apr 21, 2022 · 1 comment
Closed

Audit: Does not allow abortion with ExitCode::Ok #255

jennijuju opened this issue Apr 21, 2022 · 1 comment
Labels
Milestone

Comments

@jennijuju
Copy link
Member

brought by @anorth from the internal audit, that FVM ExitCode enumeration might be inappropriate for use in actors.

After initial investigation, we may confirm FVM DOES guarantee that aborts cannot be done with Ok exit code. ⇒ overrides to SysErrIllegalExitCode. Then the API that builtin-actors uses should not allow actors to abort with ExitCode::Ok - this might be included in the ExitCode refactor already, this ticket is to confirm that's the right assumption.

@anorth
Copy link
Member

anorth commented Apr 21, 2022

Duplicate of #144. Fixed by #191 and will improve further with #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

3 participants