Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ci: request contents read permissions explicitly in gha #12055

Merged
merged 1 commit into from
May 28, 2024

Conversation

galargh
Copy link
Contributor

@galargh galargh commented May 28, 2024

Related Issues

n/a

Proposed Changes

Request contents read permissions explicitly in GitHub Actions.

Additional Info

This permissions are granted implicitly in public repositories (like lotus), but need to be requested explicitly in private repositories (like lotus-priv). This change will allow us to finish the migration of lotus-priv to GHA.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Copy link

github-actions bot commented May 28, 2024

All checks have passed

@galargh galargh enabled auto-merge (squash) May 28, 2024 10:36
@galargh galargh merged commit 47fde12 into master May 28, 2024
96 checks passed
@galargh galargh deleted the ipdx/explicit-read-permissions branch May 28, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants