Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eth_getBlockReceipts should work similarly as geth #12539

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

aarshkshah1992
Copy link
Contributor

Closes #12530 AND #12536.

Tested on a local node as well:

curl --location --request POST 'http://localhost:1234/rpc/v1' --header 'Content-Type: application/json' --data-raw '{ "jsonrpc":"2.0","method":"eth_getBlockReceipts","params":["0xc6b5584814d4872c4050c725fa2bdc2b1d23e8d63ae10db6ce7e6aeef5f4623d"],"id":1}'
{"id":1,"jsonrpc":"2.0","result":[]}
curl --location --request POST 'http://localhost:1234/rpc/v1' --header 'Content-Type: application/json' --data-raw '{ "jsonrpc":"2.0","method":"eth_getBlockReceipts","params":["0xdc7c0197634c7c03adf6c3b44559009bc81278269183e97be4974b65c6425ccf"],"id":1}'
{"error":{"code":1,"message":"failed to get tipset: cannot get tipset by hash: cannot find tipset with cid bafy2bzacedohyamxmnghya5n63b3irkzacn4qetye2iyh2l34sluwzogijom6: ipld: could not find bafy2bzacedohyamxmnghya5n63b3irkzacn4qetye2iyh2l34sluwzogijom6"},"id":1,"jsonrpc":"2.0"}

@aarshkshah1992 aarshkshah1992 self-assigned this Oct 1, 2024
@aarshkshah1992 aarshkshah1992 added the skip/changelog This change does not require CHANGELOG.md update label Oct 1, 2024
@rjan90 rjan90 mentioned this pull request Oct 1, 2024
51 tasks
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 nice unit tests

@aarshkshah1992 aarshkshah1992 merged commit 918a68f into master Oct 2, 2024
83 of 85 checks passed
@aarshkshah1992 aarshkshah1992 deleted the fix/eth-get-block-receipts branch October 2, 2024 05:23
@aarshkshah1992
Copy link
Contributor Author

@rjan90 Merged this.

rjan90 pushed a commit that referenced this pull request Oct 2, 2024
dumikau pushed a commit to protofire/lotus that referenced this pull request Oct 2, 2024
rjan90 pushed a commit that referenced this pull request Oct 3, 2024
rjan90 pushed a commit that referenced this pull request Oct 3, 2024
rjan90 added a commit that referenced this pull request Oct 3, 2024
* chore: bump version, make gen, make docsgen-cli

chore: bump version, make gen, make docsgen-cli

* chore: bump go-multiaddr-dns to v0.4.0 (#12540)

* chore: bump go-multiaddr-dns version

chore: bump go-multiaddr-dns version

* chore: add changelog entry

chore: add changelog entry

* parse block hash as a free param (#12539)

* chore(build): update minimum go-version (#12459)

* chore(build): update minimum go-version

chore(build): update minimum go-version

* chore: min go-version warning in changelog

chore: min go-version warning in changelog

* chore: update PR-number in changelog

chore: update PR-number in changelog

* chore: update go-version in actors-test

chore: update go-version in actors-test

* chore: update changelog for v1.29.2

chore: update changelog for v1.29.2

---------

Co-authored-by: Aarsh Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

It seems that the latest eth_getBlockReceipts doesn't properly work when querying for block hash
3 participants