Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap 2nd gen onCall functions with trace context #1491

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Wrap 2nd gen onCall functions with trace context #1491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c476f2a
wrap oncall functions with trace context
blidd-google Nov 28, 2023
55c7223
update changelog
blidd-google Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Wrap 2nd gen onCall functions with trace context. (#1491)
4 changes: 3 additions & 1 deletion src/v2/providers/https.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ export function onCall<T = any, Return = any | Promise<any>>(
// onCallHandler sniffs the function length to determine which API to present.
// fix the length to prevent api versions from being mismatched.
const fixedLen = (req: CallableRequest<T>) => handler(req);
const func: any = onCallHandler(
let func: any = onCallHandler(
{
cors: { origin, methods: "POST" },
enforceAppCheck: opts.enforceAppCheck ?? options.getGlobalOptions().enforceAppCheck,
Expand All @@ -375,6 +375,8 @@ export function onCall<T = any, Return = any | Promise<any>>(
fixedLen
);

func = wrapTraceContext(func);

Object.defineProperty(func, "__trigger", {
get: () => {
const baseOpts = options.optionsToTriggerAnnotations(options.getGlobalOptions());
Expand Down
Loading