Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with anonymous event tracking on the docs site #121

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Aug 12, 2020

Fixes #111

This PR:

  • Does a simpler & better job of completely fuzzing non-cloud hosted docs urls
  • Does not track custom user_id in pageview events
  • Differentiates between cloud and non-cloud docs pageviews

- Do a simpler/better job of completely fuzzing non-cloud hosted docs urls
- Do not track user_id in pageview events
- Differentiate between cloud and non-cloud docs pageviews
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it! The final validation will be checking the events fired by docs hosted in dbt Cloud, once we get v0.18.0-rc1 in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revised tracking for docs, Cloud-hosted vs. localhosted
2 participants