-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dockerfile during release #3
Comments
As possible, let's also backfill the missing dockerfiles for v0.17.0 through v0.19.0 |
Update: Per @kwigley's suggestion, we should just maintain the single simple Dockerfile in dbt, not tied to any one specific version. For clarity, we should remove the older versioned Dockerfiles. We should continue to publish |
@jtcohen6 thanks for the bookkeeping 😄 |
are those USER_ID and GROUP_ID supported for the old tags like 0.18.1 ? |
Cleaned up docker resources in the dbt repo here dbt-labs/dbt-core#3019 Still need to update the dbt-release scripts to use dockerfile in the dbt repo for building and pushing a docker image for releases. |
@edbizarro are you referring to the development docker image? The Dockerfile we use to publish dbt as a docker image to Docker Hub can be found here https:/fishtown-analytics/dbt/pull/3019/files#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddc. Does this help with your question? |
Currently, the dbt release flow:
It does not:
This gives the appearance of our not maintaining docker files / images for each version of dbt, when that's not true. We should either:
The text was updated successfully, but these errors were encountered: