Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgresql dependency query speedup #1192

Conversation

patrickgoss
Copy link

@patrickgoss patrickgoss commented Dec 19, 2018

Closes #1193

split the relationship CTE in order to speed the dependency query on large postgres dbs

@drewbanin
Copy link
Contributor

Hey @patrickgoss - I like to create issues for every PR that we merge. This helps at release time when I need to write up the Changelog. Can you provide us with a brief summary of why you made this change, and how this change addresses the problem you're having? I can backfill an issue with that info :)

I think this looks pretty good, but I'd like to kick off the whole test suite (happy to do that) and give it some functional testing as well. Would also love if @beckjake could take a quick look at this

@patrickgoss
Copy link
Author

patrickgoss commented Dec 19, 2018

Should resolve #1193

I've ran the test suite according to 'CONTRIBUTING.md', though it would be good to have someone else double check. I also tested to see if dbt run would work again on our database and it did!

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've triggered the tests, assuming they pass this looks great to me! This will create some merge conflicts, but it will be easy to resolve, so let's get this in before #1145

@drewbanin
Copy link
Contributor

Merging this - thanks @patrickgoss :)

@drewbanin drewbanin merged commit d7610a7 into dbt-labs:dev/stephen-girard Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants