-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace embedded adapter SQL with macros #1204
Milestone
Comments
beckjake
added a commit
that referenced
this issue
Jan 16, 2019
…verything Convert all embedded adapter SQL into macros (#1204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature
dbt should not have embedded SQL in adapter code. Instead, those things should just be written as macros that pass any necessary information into
execute_macro
Feature description
There are quite a few places in dbt where queries to the information schema, etc are hardcoded as format()'able strings inside adapter methods. With the new execute_macro behavior, it should be super easy to directly translate those into macros!
Who will this benefit?
This will make it easier to leverage dbt's macro/adapter_macro system for writing new adapters. Currently you have to embed SQL into the adapter in some places and macros in other places, it's not very consistent or predictable.
The text was updated successfully, but these errors were encountered: