-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace instances of dbt.exceptions with exceptions #1569
Comments
Hi @drewbanin, if I look at this, which branch should I fork from? Apologies if this was addressed in the contributing file and I missed it. Thank you! |
Hey @aminamos - our current development branch is I'll have a think about how to better document this. Let me know if you have any questions as you dig into it! |
I submitted an initial pull request with the fixed macros to make sure I am on the right track. I do have one question: should I update the Python files as well? |
Hey @aminamos - I'll follow up on this in the PR! |
Issue
Issue description
Some default implementations of dbt macros reference
dbt.exceptions
instead ofexceptions
, leading to errors likeIn many (all?) of these cases, the macro is raising a "not implemented" exception, so this is a low-impact bug, but one worth fixing for sure.
Results
dbt raises the incorrect error message
System information
The output of
dbt --version
:Steps to reproduce
This only really happens when you try to build a new adapter.
list_relations_without_caching
The text was updated successfully, but these errors were encountered: