-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quote
parameter to accepted_values
test
#1873
Labels
enhancement
New feature or request
Milestone
Comments
You can change |
Wasn't sure how that worked in Jinja, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
Currently only character values can be tested in the built-in
accepted_values
test.Relevant code from
accepted_values.sql
To support testing both accepted numeric and character values, we should make quoting the values optional.
Additional context
https://getdbt.slack.com/archives/C2JRRQDTL/p1572299083481900
Per a Slack conversations with Claire and Drew, this should not break existing uses of this test.
Drew suggested added a
quote
parameter, the default of which should betrue
, which is the current behavior.Proposed change
Who will this benefit?
All users that use the
accepted_values
test.The text was updated successfully, but these errors were encountered: