Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IAM parameters to redshift adapter #1995

Closed
gfeldman opened this issue Dec 10, 2019 · 1 comment · Fixed by #2262
Closed

Adding IAM parameters to redshift adapter #1995

gfeldman opened this issue Dec 10, 2019 · 1 comment · Fixed by #2262
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! redshift

Comments

@gfeldman
Copy link

Describe the feature

I would the arguments to get_cluster_credentials to be added to the dbt profile configuration. In particular DbGroups to allow the temporary user to be added to a group and AutoCreate to allow auto creation of users that do not exist.

Describe alternatives you've considered

Since these are IAM specific configurations the only other alternative is to not use the temporary credentials.

Additional context

This is a feature specifically for redshift users.

Who will this benefit?

This feature will be useful for dbt users who want to use temporary and dynamic credentials with redshift.

@gfeldman gfeldman added enhancement New feature or request triage labels Dec 10, 2019
@drewbanin drewbanin added redshift good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Dec 10, 2019
@drewbanin
Copy link
Contributor

Thanks for making this issue @gfeldman!

If you're interested in contributing a code change for this feature, the relevant code should be around here:
https:/fishtown-analytics/dbt/blob/40839c79fcf1854942f8db44d1a2648bffe0a2ab/plugins/redshift/dbt/adapters/redshift/connections.py#L39-L57

and here https:/fishtown-analytics/dbt/blob/40839c79fcf1854942f8db44d1a2648bffe0a2ab/plugins/redshift/dbt/adapters/redshift/connections.py#L87-L128

It sounds like we'll just need to state these two configs (DbGroups and AutoCreate) in the set of whitelisted RedshiftCredentials, then pass them through to boto_client.get_cluster_credentials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! redshift
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants