Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source doesn't allow usage of dataset and project aliases #2133

Closed
1 of 5 tasks
preston-hf opened this issue Feb 13, 2020 · 2 comments · Fixed by #2244
Closed
1 of 5 tasks

Source doesn't allow usage of dataset and project aliases #2133

preston-hf opened this issue Feb 13, 2020 · 2 comments · Fixed by #2244
Assignees
Labels
bug Something isn't working

Comments

@preston-hf
Copy link

Describe the bug

Most everywhere else in DBT, database is synonymous to project, and dataset is synonymous to schema. In sources, this is not the case, and they are unexpected parameters. This is very confusing to end users looking at code with project and dataset everywhere else, they'll not even be familiar with what database and schema are, as these names don't appear anywhere in bigquery.

Steps To Reproduce

Attempt to specify the dataset or project of a source in schema.yml

Expected behavior

Schema and dataset should be interchangeable, as should database and project

Screenshots and log output

dditional properties are not allowed ('project', 'dataset' were unexpected)

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt --version:

0.15.2
@preston-hf preston-hf added bug Something isn't working triage labels Feb 13, 2020
@drewbanin drewbanin added bigquery good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Feb 18, 2020
@drewbanin
Copy link
Contributor

Thanks for the report @preston-hf! This does appear to be an oversight on our part.

Would you be interested in contributing a fix? If so, happy to help point you in the right direction!

@drewbanin drewbanin added this to the Octavius Catto milestone Feb 27, 2020
@drewbanin drewbanin self-assigned this Feb 28, 2020
@drewbanin drewbanin added help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors and removed bigquery help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors good_first_issue Straightforward + self-contained changes, good for new contributors! labels Feb 28, 2020
@drewbanin
Copy link
Contributor

+let's make sure to improve documentation for these aliases when we make this change

beckjake added a commit that referenced this issue Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants