Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render overridden sources twice in docs site #2284

Closed
drewbanin opened this issue Apr 1, 2020 · 3 comments · Fixed by #2399
Closed

Don't render overridden sources twice in docs site #2284

drewbanin opened this issue Apr 1, 2020 · 3 comments · Fixed by #2399
Assignees
Labels
dbt-docs [dbt feature] documentation site, powered by metadata artifacts enhancement New feature or request packages Functionality for interacting with installed packages

Comments

@drewbanin
Copy link
Contributor

Describe the feature

If a project overrides a source declared in a package, the docs site will render the source twice in the DAG view (and probably the file tree, too). Let's update the docs site to reflect the logical source constructed by dbt.

@beckjake can you advise what changes, if any, should take place in the compiled manifest? I'd be relatively happy with some JS logic in the docs site to merge sources together, but the more work dbt can do here, the better! Any chance we can have sources indicating which other sources they override, or which sources override them?

@drewbanin drewbanin added enhancement New feature or request dbt-docs [dbt feature] documentation site, powered by metadata artifacts packages Functionality for interacting with installed packages labels Apr 1, 2020
@drewbanin drewbanin added this to the Octavius Catto milestone Apr 1, 2020
@beckjake
Copy link
Contributor

beckjake commented Apr 1, 2020

I've thought about this a bit in the context of ref, and doc too. When we are parsing, we collect docrefs, refs, and sources - but only the literal arguments received. During compilation, we could either change those values (seems bad) or add new fields indicating the UIDs that were actually selected.

We almost do this with the depends_on value, but it only includes nodes. Maybe we could extend that to sources and docs as well?

@drewbanin
Copy link
Contributor Author

The code change here appears to be pretty minimal - AFAICT from testing out #2357 in dev, it looks like we just need to point to manifest.sources instead of manifest.nodes in some places.

@drewbanin drewbanin self-assigned this Apr 29, 2020
@drewbanin
Copy link
Contributor Author

fix is here: dbt-labs/dbt-docs#87

Going to smoke test this change some more, then PR the index.html file in dbt

drewbanin added a commit that referenced this issue May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt-docs [dbt feature] documentation site, powered by metadata artifacts enhancement New feature or request packages Functionality for interacting with installed packages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants