-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use adapter macro pattern for core schema tests #2415
Comments
The thing that will be less good about this—until we have a better answer (#2301, #2302)—is that it wouldn't be possible to override a builtin schema test from the root project. The ability to change the behavior of the |
@jtcohen6 I think you still could! The macro from the project can just override the base macro name. This issue is only a problem for plugins, because plugin macros live in the |
Oh, you're right! So even though you couldn't override |
Describe the feature
Let's use the adapter macro pattern to implement dbt's core schema tests. This will allow package maintainers to override the mechanics of the SQL for their plugin if need be.
Describe alternatives you've considered
Change macro loading precedence to allow plugin maintainers to override the macros directly? That feels worse.
Who will this benefit?
The text was updated successfully, but these errors were encountered: