Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for extra spacing and parentheses for BigQuery views #2422

Merged
merged 3 commits into from
May 12, 2020
Merged

Fix for extra spacing and parentheses for BigQuery views #2422

merged 3 commits into from
May 12, 2020

Conversation

azhard
Copy link
Contributor

@azhard azhard commented May 8, 2020

resolves #2421

Description

Fixes extra spacing and parentheses when using dbt to create BigQuery views

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 8, 2020
@drewbanin drewbanin self-requested a review May 12, 2020 13:22
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @azhard - thanks for putting the time in on this one :)

@drewbanin drewbanin merged commit fd662a1 into dbt-labs:dev/octavius-catto May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra parentheses and spacing when creating BigQuery views
2 participants