-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug exit code does not match connection test #3017
Comments
@sdebruyn I agree. If Is this a change you'd be interested in contributing? |
Sure :) Am I correct to assume that these 2 files are the only ones I'd need to change? |
That sounds right to me! We define an ( I think you'd want to pull that into |
Describe the bug
When I run
dbt debug
, I would expect a successful exit code (0) when the connection test succeeds and an error code (>0) when the connection test fails. In0.18.1
the exit code is always 0, regardless of the result of the test.Steps To Reproduce
dbt debug
(connection test should succeed)echo $?
- observe that the output is0
dbt debug
(connection test should fail)echo $?
- observe that the output is still0
Expected behavior
A strictly positive exit code when the connection test fails.
Screenshots and log output
Mentioned in repro
System information
Any database
The output of
dbt --version
:**The operating system you're using: Debian Buster
The output of
python --version
:Python 3.8.7
The text was updated successfully, but these errors were encountered: