Fix incorrect error message (trivial)

[ran-eh]

resolves #

Description

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

[jtcohen6]

Thanks for the PR @ran-eh! I'm not opposed to changing this error message in the spirit of making it clearer. I am curious to hear, in what way do you feel that the current language is incorrect?

Because alert_non_existence adjudicates each of (potentially many) selection criteria, it's possible that one criterion does not match any nodes while another does. To my mind, the phrase nothing to do is a bit confusing in such a case:

$ dbt run -m fct_sprints asdfgh
...
The selector 'asdfgh' does not match any nodes - nothing to do

14:21:31 | Concurrency: 8 threads (target='dev')
14:21:31 |
14:21:31 | 1 of 1 START table model dbt_jcohen.fct_sprints...................... [RUN]

Perhaps we could simplify this message to just: The selection criterion 'asdfgh' does not match any nodes. (While we're here, we may as well disambiguate from YAML selectors / --selector, too.)

[ran-eh]

Thanks for the PR @ran-eh! I'm not opposed to changing this error message in the spirit of making it clearer. I am curious to hear, in what way do you feel that the current language is incorrect?

Because alert_non_existence adjudicates each of (potentially many) selection criteria, it's possible that one criterion does not match any nodes while another does. To my mind, the phrase nothing to do is a bit confusing in such a case:

$ dbt run -m fct_sprints asdfgh
...
The selector 'asdfgh' does not match any nodes - nothing to do

14:21:31 | Concurrency: 8 threads (target='dev')
14:21:31 |
14:21:31 | 1 of 1 START table model dbt_jcohen.fct_sprints...................... [RUN]

Perhaps we could simplify this message to just: The selection criterion 'asdfgh' does not match any nodes. (While we're here, we may as well disambiguate from YAML selectors / --selector, too.)

Agreed and changed.

[jtcohen6]

Thanks for this @ran-eh!

[jtcohen6]

Whoops, sorry for the over-eager approval. One tiny change and then this should be fit to ship.