git package: warn if specified revision master, main

[jtcohen6]

Follow up from #3057, #3104

Previously, if a git package was unpinned, dbt tried to install it from master (hard coded). In #3104, this was fixed to used HEAD (default branch, regardless of name) and continue to warn if unpinned.

We'd like to warn as well if the user specifies the package revision as 'master' or 'main', since either almost certainly represents the default branch. Users can disable the warning with warn-unpinned: false.

Example

packages:
  - git: https:/fishtown-analytics/dbt-codegen 
    revision: master
  - git: https:/tailsdotcom/dbt_artifacts   
    revision: main
  - git: https://gitlab.com/gitlab-data/snowflake_spend
  - package: fishtown-analytics/audit_helper
    version: 0.3.0

$ dbt deps

Running with dbt=0.19.0
WARNING: The git package "https:/fishtown-analytics/dbt-codegen"
	is pinned to the "master" branch.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https:/tailsdotcom/dbt_artifacts"
	is pinned to the "main" branch.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://gitlab.com/gitlab-data/snowflake_spend"
	is not pinned, using HEAD (default branch).
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https:/fishtown-analytics/dbt-codegen"
	is pinned to the "master" branch.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https:/tailsdotcom/dbt_artifacts"
	is pinned to the "main" branch.
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
WARNING: The git package "https://gitlab.com/gitlab-data/snowflake_spend"
	is not pinned, using HEAD (default branch).
	This can introduce breaking changes into your project without warning!

See https://docs.getdbt.com/docs/package-management#section-specifying-package-versions
Installing https:/fishtown-analytics/dbt-codegen@master
  Installed from revision master

Installing https:/tailsdotcom/dbt_artifacts@main
  Installed from revision main

Installing https://gitlab.com/gitlab-data/snowflake_spend@HEAD
  Installed from HEAD (default branch)

Installing fishtown-analytics/[email protected]
  Installed from version 0.3.0

Installing fishtown-analytics/[email protected]
  Installed from version 0.6.4

packages:
  - git: https:/fishtown-analytics/dbt-codegen 
    revision: master
    warn-unpinned: false
  - git: https:/tailsdotcom/dbt_artifacts   
    revision: main
    warn-unpinned: false
  - git: https://gitlab.com/gitlab-data/snowflake_spend
    warn-unpinned: false
  - package: fishtown-analytics/audit_helper
    version: 0.3.0

$ dbt deps

Running with dbt=0.19.0
Installing https:/fishtown-analytics/dbt-codegen@master
  Installed from revision master

Installing https:/tailsdotcom/dbt_artifacts@main
  Installed from revision main

Installing https://gitlab.com/gitlab-data/snowflake_spend@HEAD
  Installed from HEAD (default branch)

Installing fishtown-analytics/[email protected]
  Installed from version 0.3.0

Installing fishtown-analytics/[email protected]
  Installed from version 0.6.4

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

[clrcrl]

LGTM!

[kwigley]

nice! I do think we should warn when using any branch name to pin, but this is a step in that direction 👍

[jtcohen6]

nice! I do think we should warn when using any branch name to pin, but this is a step in that direction 👍

@kwigley Do you mean, warn if users pin to a branch name in their revision, rather than a version number/release tag? That's fair! I don't think the git-based deps approach has a way today to differentiate between branch-name and release-name revisions.