-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could the dataclasses
requirement be relaxed?
#3150
Comments
Hey @bastienboutonnet, this is totally reasonable! The slightly tricky piece here is that the pinned If you wanted to bump the
By the by, both of the 'dataclasses==0.6;python_version<"3.7"' The dataclass functionality is native to python 3.7 and above; the I'm going to close this issue only because it's a duplicate of dbt-labs/hologram#39, which I transferred from here to there in January. I'll also add a comment there with the same information I've mentioned above. |
@jtcohen6 cool makes sense. I'll do all that at some point this week. And yeah I was aware of the shenanigans for only p36 but I guess until support for 36 is dropped in dbt it probably makes sense to still PR this change for the time being. Thanks for the clear instructions! |
Describe the feature
Not really a feature... not really a bug
the hard requirement on dataclasses (https:/fishtown-analytics/dbt/blob/develop/core/setup.py#L72) makes dbt not really friendly if it has to cohabit with https:/willmcgugan/rich which requires dataclasses
>=0.7
.I don't think it's a problem for a lot of people but it has come up when I wanted to make
dbt
a requirement of a CLI dbt helper I'm building https:/bitpicky/dbt-sugarIt should be fine for most people as they will most likely have installed dbt prior to installing dbt-sugar so the dependency resolver shouldn't go haywire and we instruct people to install dbt sugar using pipx which installs the tool in its own venv but makes it available globally but it could be funky for some users... Who knows.
Anyway, I thought I'd raise this and if dbt doesn't need this very specific version the requirement could be relaxed to something like
>=0.6,<0.9
or so.The text was updated successfully, but these errors were encountered: