Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbt downloads bumpversion.cfg when it doesn't need it #907

Closed
drewbanin opened this issue Aug 8, 2018 · 2 comments
Closed

dbt downloads bumpversion.cfg when it doesn't need it #907

drewbanin opened this issue Aug 8, 2018 · 2 comments
Assignees
@beckjake
Milestone
0.11.0 - Isaac As...

Comments

@drewbanin
Copy link
Contributor

Issue description

In main.py, dbt imports version.py. At the bottom of version.py, dbt will always fetch the .bumpversion.cfg file to determine the latest version of dbt.

dbt should instead only fetch the latest version from github if dbt --version is run.

This happens on dbt v0.10.2.
@thenaturalist
Copy link

This behaviour currently completely breaks dbt when trying to run it offline.

@beckjake beckjake self-assigned this Aug 24, 2018
beckjake added a commit that referenced this issue Aug 28, 2018
@beckjake
Merge pull request #949 from fishtown-analytics/selectively-download-…
6060146 
…bumpversion

Remove unconditional calls to get_latest_version (#907)
@beckjake
Copy link
Contributor

Fixed in #949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beckjake beckjake

Labels
None yet
Projects
None yet
Milestone
0.11.0 - Isaac Asimov (unreleased)
Development

No branches or pull requests
3 participants
@beckjake @drewbanin @thenaturalist