Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add --warn-error flag #1347

Merged
merged 1 commit into from
Mar 12, 2019
Merged

re-add --warn-error flag #1347

merged 1 commit into from
Mar 12, 2019

Conversation

drewbanin
Copy link
Contributor

@beckjake I'm a little worried this got lost in a merge somehow? It was merged over here but it's not currently present in main.py. Is there a good way to figure out where we lost it (and if we lost anything else?)

@drewbanin drewbanin requested a review from beckjake March 11, 2019 23:43
@drewbanin drewbanin added this to the Stephen Girard milestone Mar 11, 2019
@beckjake
Copy link
Contributor

I think this was lost in the merge+rebase madness that happened during source freshness' merging. Git bisect is actually very confused about this and tells me that there are no commits where the change happens... I've got a commit where it was added, and one where it was removed, and I can't figure out where it happened in between. Everything looks fine with this now though.

@drewbanin drewbanin merged commit a981f65 into dev/stephen-girard Mar 12, 2019
@drewbanin drewbanin deleted the fix/warn-error-flag branch March 12, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants