Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update broken profiles.yml link #1366

Merged
merged 1 commit into from
Mar 24, 2019
Merged

Update broken profiles.yml link #1366

merged 1 commit into from
Mar 24, 2019

Conversation

emilieschario
Copy link
Contributor

Issue

Closes #1344

Solution

This MR:

  • replaces the existing (broken) link to the docs where there is a functional, accurate sample profile. This is a great link to point to because the docs are extremely likely to stay updated as the requirements for the profiles.yml file changes (rather than another thing to be maintained).

@drewbanin drewbanin added this to the Wilt Chamberlain milestone Mar 24, 2019
@drewbanin
Copy link
Contributor

Thanks for the contribution @emilieschario! This LGTM - are you ready for me to merge this?

@drewbanin drewbanin self-requested a review March 24, 2019 16:07
@emilieschario
Copy link
Contributor Author

Ready whenever you are!

@drewbanin drewbanin merged commit e45ed0e into dbt-labs:dev/wilt-chamberlain Mar 24, 2019
@jtcohen6 jtcohen6 mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Wilt Chamberlain
Development

Successfully merging this pull request may close these issues.
2 participants
@emilieschario @drewbanin