Support ephemeral nodes (#1368) #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
fix/rpc-ephemeral-clean
branch
from
e05858a
to
c6ca240
Compare
beckjake
force-pushed
the
fix/rpc-ephemeral-clean
branch
from
c6ca240
to
9373a45
Compare
cmcarthur
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
looks straightforward enough. it seems totally fine to leave node in here for debugging. and architecturally i think passing the manifest into the task as an arg is more consistent with our long term vision for this than generating the manifest in the task constructor.
|
that test failure looks transient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1368
Pass along the manifest we compiled instead of loading a new one, so ephemeral nodes now get compiled properly.
As part of debugging, I split up request handling and attached nodes to the results (they don't get serialized), which I'd like to keep.