Allow vars to be set to null and differentiate them from unset vars (#608) #1426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #608
Fix #608 by distinguishing between
None
variables and not having a variable set at all.Potentially of interest - I had to remove a test that explicitly ensured that we did not allow variables to be
None
. I assume that All Tests Exist For A Reason, though of course the reason might very well be "we used to think this was a good idea and now we don't".