fix for unpickleable datetime tzs set by snowflake #1670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
snowflake-connector-python
library does something... surprising... when handling timezones. It dynamically generates its own timezone objects which are not pickleable. As a result, simple queries like:will fail if run on the rpc server. This happens specifically when data is passed between subprocesses over a queue.
Relevant issue: snowflakedb/snowflake-connector-python#81
Relevant code: converter.py#L140
I'm unsure if the approach I took here is a good one. I think I'd prefer for this code to live closer to the RPC server, but wasn't exactly sure if we had a good place to put this today. Very open to feedback / insight here.