New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test metadata for schema tests, add test tests (#1154) #1816

Merged

beckjake merged 1 commit into dev/louisa-may-alcott from feature/test-nodes-include-name-kwargs

Oct 10, 2019

Contributor

beckjake commented Oct 8, 2019

Fixes #1154

Add a new optional metadata field to the ParsedTestNode. On data tests it's None, but on schema tests it's a dict with 3 entries:

(optional) the namespace, if you had a dotted test name
The test name, without the namespace if it was dotted
The test arguments, including the column name if it was a column test


add test metadata for schema tests, add test tests

a2691d5

cla-bot bot added the cla:yes label

drewbanin approved these changes

View reviewed changes

Contributor

drewbanin left a comment

This is beautiful, let's ship it

beckjake merged commit 6d2aca1 into dev/louisa-may-alcott

beckjake deleted the feature/test-nodes-include-name-kwargs branch

October 10, 2019 11:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment