pin psycopg2 (#1221) #1898
Merged
pin psycopg2 (#1221) #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1221
See this comment for the reasoning here.
Rev psycopg2 to 2.8.x
Remove
psycopg2from redshift's dependencies since it's inherited from postgres anywayInstall
psycopg2-binaryby default on 3.8,psycopg2otherwiseIf the
DBT_PSYCOPG2_NAMEenvironment variable is present during installation, dbt will require that name instead (even if it is a stupid request like a-binaryon an unsupported platform).We don't restrict this to only
psycopg2-binaryandpsycopg2, but we could.This flag doesn't change the package version.