Clickable doc serve URL #2131
Clickable doc serve URL #2131
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @aaronsteers |
|
@drewbanin - Thanks for your review of the previous PR (#2027). Resubmitted as requsted with the target Thanks! 👍 |
|
Thanks @aaronsteers - this looks pretty good to me! Are you able to sign the CLA attached above? It's a little funny for this PR, but we do require all contributors to sign the CLA as a policy. Let me know! |
|
@drewbanin - This is complete. Thx! |
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @aaronsteers |
|
Tried pushing an additional commit to see if CLA bot would be happy - no go unfortunately. Please lmk if I need to take some additional action. Thanks! |
|
@aaronsteers sorry bout that - you're all set now! Thanks! @cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Thanks for your contribution @aaronsteers! Merging this one :)
|
Awesome, thanks @drewbanin! |
Fixes #2027 - this resolves an issue where the period ('.') after the URL causes hyperlink-detection to work incorrectly in tools like VS Code.
Before this fix, the link is clickable but the user does not reach the desired page due to the included '.' in the passed url.
After this fix, the link is clickable and also directs to the correct URL.