add generate_database_name macro (#1695) #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
changed the title
drewbanin
approved these changes
Feb 19, 2020
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ### Features | |||
| - Add a "docs" field to models, with a "show" subfield ([#1671](https:/fishtown-analytics/dbt/issues/1671), [#2107](https:/fishtown-analytics/dbt/pull/2107)) | |||
| - Add support for generating database name macro ([#1695](https:/fishtown-analytics/dbt/issues/1695), [#2143](https:/fishtown-analytics/dbt/pull/2143)) | |||
There was a problem hiding this comment.
Can we add a separate entry for the breaking change that 1-arg generate_schema_name macros are no longer supported?
beckjake
force-pushed
the
feature/generate-database-name
branch
from
b257056
to
4b14311
Compare
added 2 commits
February 24, 2020 08:39
Remove old deprecation tests Add new tests Fix all the integration tests that do manifest things
beckjake
force-pushed
the
feature/generate-database-name
branch
from
4b14311
to
6ca6233
Compare
This was referenced Nov 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1695
Description
Add a
generate_database_namemacroUnify the various node update things so there's some level of enforced consistency in behavior.
Tests:
Checklist
, or tests are not required/relevant for this PRCHANGELOG.mdand added information about my change to the "dbt next" section.