Use "describe table" to get the columns in a relation on snowflake (#2260) #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Apr 15, 2020
| {% if (result | length) >= maximum %} | ||
| {% set msg %} | ||
| Too many columns in relation {{ relation }}! dbt can only get | ||
| information about relations with fewer than {{ maximum }} columns. |
There was a problem hiding this comment.
i hope nobody ever sees this error message :p
There was a problem hiding this comment.
I actually don't know for sure that this is a limit, I just assumed it based on all the other commands. I'm comfortable saying that if someone has 10k columns in a table, we can revisit this then :)
| @@ -108,3 +110,46 @@ def numeric_type(cls, dtype: str, precision: Any, scale: Any) -> str: | |||
|
|
|||
| def __repr__(self) -> str: | |||
| return "<Column {} ({})>".format(self.name, self.data_type) | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
While we're in here, can we override the string_size on the SnowflakeColumn class? I think right now, the base logic looks like:
def string_size(self) -> int:
if not self.is_string():
raise RuntimeException("Called string_size() on non-string field!")
if self.dtype == 'text' or self.char_size is None:
# char_size should never be None. Handle it reasonably just in case
return 256
else:
return int(self.char_size)
But on Snowflake, we want to map TEXT, STRING, or VARCHAR (with no size specified) to VARCHAR(MAX), which is 16777216.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2260
Description
Use
describe tableto get the columns in a relation on snowflake. This requires doing some extra parsing to interpret varchars and numerics (with a regex...), but that's really all we get withdescribe table.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.