Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put protobuf in version jail #2491

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

beckjake
Copy link
Contributor

resolves (not fully so please do not autoclose) #2490

Description

Pin protobuf to >=3.6.0,<3.12.
3.11 was the last good release, 3.6 is the minimum bound supplied by googleapis-common-protos 1.6.0 (which we have locked dbt-bigquery to for other good reasons).

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Copy link
Contributor

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun stuff! lgtm

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👮

@beckjake beckjake merged commit ee6b842 into dev/octavius-catto May 27, 2020
@beckjake beckjake deleted the fix/pin-protobufs branch May 27, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants