Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add project names/filenames/values to rendering errors (#2499) #2501

Merged
merged 1 commit into from
May 29, 2020
Merged

add project names/filenames/values to rendering errors (#2499) #2501

merged 1 commit into from
May 29, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2499

Description

Add some nice information to the output on errors. The failure from the original project now looks like this:

$ dbt ls
Encountered an error:
Compilation Error
  Failed to render models/schema.yml from project minimal: Compilation Error
    Could not render {{ doc("mydoc") }}: 'doc' is undefined

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • [] This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 29, 2020
@beckjake beckjake force-pushed the fix/better-filename-errors branch from a864871 to 3b1c6e5 Compare May 29, 2020 16:20
@beckjake beckjake force-pushed the fix/better-filename-errors branch from 3b1c6e5 to 3387d08 Compare May 29, 2020 16:21
drewbanin
drewbanin approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

belissima

kwigley
kwigley approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@beckjake beckjake merged commit 594b8b7 into dev/octavius-catto May 29, 2020
@beckjake beckjake deleted the fix/better-filename-errors branch May 29, 2020 17:31
@drewbanin drewbanin mentioned this pull request Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

@kwigley kwigley kwigley approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beckjake @drewbanin @kwigley