Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write manifest when writing run_results #2799

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Sep 29, 2020

resolves #2765

Description

Added a line to write the manifest at the same time that we write the run_results.json.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Sep 29, 2020
@gshank
Copy link
Contributor Author

gshank commented Sep 29, 2020

I didn't add a test because we already have a lot of tests for manifest.json and the only difference here is that it's written a bit later.

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice straightforward addition.

From the issue:

TBD if this should be done a second time or if we should skip the current write that occurs after parsing finishes.

We can decide later if we want to remove the post-parsing manifest write, as part of our upcoming performance tuning.

@gshank gshank merged commit 3f45abe into dev/kiyoshi-kuromiya Oct 1, 2020
@kwigley kwigley deleted the feature/2765-save-manifest branch February 5, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

At the end of a dbt run, write the manifest
3 participants