Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-instate hard-deleted records during snapshot #2821

Conversation

joelluijmes
Copy link
Contributor

@joelluijmes joelluijmes commented Oct 8, 2020

resolves #2819

Description

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Oct 8, 2020
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @joelluijmes! Nice work on adding the test for "revived" records. (I also quite like that as a descriptor.)

  • Could you add a changelog entry?
  • For economy's sake, you could cut the now-redundant filters (where snapshotted_data.dbt_valid_to is null) further down in the snapshot_staging_table macro

@joelluijmes
Copy link
Contributor Author

Oh wups, didn't even see those filters 😅
Didn't think changelog entry was necessary as this feature kinda should have been present in the original PR. But I'll add it nevertheless 👍

@joelluijmes
Copy link
Contributor Author

BQ test fails, but doesn't seem this change could have introduced it I'd say?

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that test failure was a one-off, all is well upon re-running.

Thanks for the contribution @joelluijmes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-instate hard-deleted records during snapshot
2 participants