Respect --project-dir in dbt clean command

[feluelle]

resolves #2840

Description

To fix this issue I changed the code to move_to_nearest_project_dir before running the clean command. So it will clean the correct locations.

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @feluelle

[jtcohen6]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[jtcohen6]

Looks good @feluelle! Could you add a changelog entry beneath v0.19.0 (either "under the hood" or a new "fixes" section), and add yourself to the list of contributors?

[feluelle]

@jtcohen6 There was a typo - 2871 instead of 2817.

[feluelle]

Apart from the test I added, how can I manually check that the correct location will be cleaned. The thing is that it worked before for the current directory. So it didn't raise an error. I want to check that it removes the correct dirs and files.

[jtcohen6]

how can I manually check that the correct location will be cleaned

As in local testing? I think I understand what you mean: how to, as a step after running dbt clean in the test you added, confirm that the clean-paths have actually been cleaned. Could you use os.path.isdir(), and check for target, dbt_modules, etc?

[feluelle]

Yes. (I don't know what I meant by manually :D) I will add that.

[feluelle]

@jtcohen6 I added a test to ensure all directories specified in clean_targets were deleted by dbt clean.

[jtcohen6]

Test looks great! Thanks for the contribution @feluelle