Use diff file path for big seed checksum #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
gshank
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2927
Description
absolute_pathwithoriginal_file_pathin the checksum of big seeds (> 1 MB)Checklist
This PR includes tests, or tests are not required/relevant for this PR— I updated existing tests. I could try to write a new, replicating this specific issue, if you think it's worthwhile. Basically we'd need to instantiate a project with a big seed, move the entire project within the filesystem (but not the seed within that project), and check to see if it'll be marked modified.CHANGELOG.mdand added information about my change to the "dbt next" section.