Preload all project files at start of parsing [#3244] #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
force-pushed
the
load_all_files
branch
3 times, most recently
from
dc6350f
to
3614ce0
Compare
kwigley
approved these changes
Apr 13, 2021
Comment on lines
+99
to
+108
| project_files['SchemaParser'] = read_files_for_parser( | ||
| project, files, project.all_source_paths, '.yml', ParseFileType.Schema, | ||
| ) | ||
|
|
||
| # Also read .yaml files for schema files. Might be better to change | ||
| # 'read_files_for_parser' accept an array in the future. | ||
| yaml_files = read_files_for_parser( | ||
| project, files, project.all_source_paths, '.yaml', ParseFileType.Schema, | ||
| ) | ||
| project_files['SchemaParser'].extend(yaml_files) |
There was a problem hiding this comment.
This is new behavior, but I think it is desirable. This allows users to have schema.yaml and schema.yml files, right? Just wanted to call this out
There was a problem hiding this comment.
Yes. I realized it was easier to just accept .yaml files instead of going to the work of finding them and issuing an error.
iknox-fa
approved these changes
Apr 13, 2021
jtcohen6
approved these changes
Apr 13, 2021
core/dbt/tracking.py
Outdated
| @@ -28,7 +28,7 @@ | |||
| PACKAGE_INSTALL_SPEC = 'iglu:com.dbt/package_install/jsonschema/1-0-0' | |||
| RPC_REQUEST_SPEC = 'iglu:com.dbt/rpc_request/jsonschema/1-0-1' | |||
| DEPRECATION_WARN_SPEC = 'iglu:com.dbt/deprecation_warn/jsonschema/1-0-0' | |||
| LOAD_ALL_TIMING_SPEC = 'iglu:com.dbt/load_all_timing/jsonschema/1-0-0' | |||
| LOAD_ALL_TIMING_SPEC = 'iglu:com.dbt/load_all_timing/jsonschema/1-0-1' | |||
There was a problem hiding this comment.
Checked locally to confirm. This context is appropriately collected with 1-0-2 and not with 1-0-1.
Suggested change
| LOAD_ALL_TIMING_SPEC = 'iglu:com.dbt/load_all_timing/jsonschema/1-0-1' | |
| LOAD_ALL_TIMING_SPEC = 'iglu:com.dbt/load_all_timing/jsonschema/1-0-2' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3244
Description
As part of the project to improve partial parsing, we are changing the parsing flow to load all files at once, for easy comparison to a previously saved state.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.