[moving fix to current release] Fix ephemeral model compilation #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 4, 2021 08:39
…e-sql Fix compiled sql for ephemeral models
gshank
approved these changes
May 4, 2021
jtcohen6
approved these changes
May 4, 2021
There was a problem hiding this comment.
LGTM! Thanks for the quick reaction time!
It looks like #3139 was merged directly into 0.19.latest, instead of merging into develop and cherry-picking onto 0.19.latest. We might avoid this in the future by always merging into develop first, unless (and only unless) it's a fix we only need for the patch version because the next minor version (develop branch) has resolved it differently (e.g. #3280).
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3317
Description
We fixed the issue with ephemeral model compilation in #3139 but it never made it to the default branch! Not sure how this happened, but will think about how to ensure this doesn't happen in the future.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.