Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop clobbering default args for test definitions #3340

Merged
merged 2 commits into from
May 12, 2021

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented May 11, 2021

resolves #3329

Description

Don't clobber default arguments when parsing jinja test tag.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 11, 2021
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this does it! All dbt-utils integration tests are passing locally (on my WIP v0.20.0 compatibility branch) when I run dbt from this branch.

@kwigley kwigley marked this pull request as ready for review May 12, 2021 13:54
@kwigley kwigley requested review from a team, gshank and iknox-fa and removed request for a team May 12, 2021 13:55
Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwigley kwigley merged commit d8c261f into develop May 12, 2021
@kwigley kwigley deleted the fix/default-test-args branch May 12, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default arg values ignored in test block signature
4 participants