Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running a snapshot with missing required configurations results in un... #3385

Merged
merged 6 commits into from
May 24, 2021

Conversation

jnatkins
Copy link
Contributor

…caught Python exception (#3381)

  • Running a snapshot with missing required configurations results in uncaught Python exception

resolves #3381

Description

Adds additional validation logic for snapshots when required configurations are not provided

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

…caught Python exception (dbt-labs#3381)

* Running a snapshot with missing required configurations results in uncaught Python exception
@cla-bot cla-bot bot added the cla:yes label May 22, 2021
@jnatkins jnatkins requested a review from jtcohen6 May 24, 2021 13:26
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @jnatkins! Thanks for the quick turnaround on this contribution. I have just one small comment re: changelog

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jnatkins!!

(looks like Azure pipes are having an incident)

@jtcohen6 jtcohen6 merged commit c0c487b into dbt-labs:develop May 24, 2021
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
…... (#3385)

* Running a snapshot with missing required configurations results in uncaught Python exception (#3381)

* Running a snapshot with missing required configurations results in uncaught Python exception

* Add fix details to CHANGELOG

* Update CHANGELOG.md

* Update invalid snapshot test with new/improved error message

* Improve changelog message and contributors addition

automatic commit by git-black, original commits:
  c0c487b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running a snapshot with missing required configurations results in uncaught Python exception
2 participants