Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/file adjustments #67

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Aug 7, 2024

PR Overview

This PR will address the following Issue/Feature: N/A This is a small PR to make under the hood changes to a few files.

This PR will result in the following new package version: N/A This will not result in a new package version.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

This PR removes or makes adjustments to files which are not necessary to the package.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • [n/a] dbt run –full-refresh && dbt test
  • [n/a] dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

  • [n/a] The appropriate issue has been linked, tagged, and properly assigned
  • [n/a] All necessary documentation and version upgrades have been applied
  • [n/a] docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • [n/a] Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

No code changes were applied, therefore no validations are required.

@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Aug 7, 2024
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review August 7, 2024 15:42
Comment on lines -8 to -9
integration_tests/package-lock.yml
integration_tests/.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines in the gitignore are actually redundant. Since we already have package-lock.yml and .DS_Store listed in the root directory gitignore, that means they will be ignored in all subdirectories as well.

Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit f867455 into main Aug 12, 2024
8 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the update/file-adjustments branch August 12, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants