[Bug] Compilation error on the end contact lists model #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: [#141]
This PR will result in the following new package version: 0.17.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🪲 Bug Fixes 🪛
fivetran_utils.enabled_vars
conditional by adding thehubspot_contact_list_member_enabled
variable inhubspot_contact_lists
to solve for compilation errors when thecontact_list
source table is not being used. Ifhubspot_contact_list_member_enabled
istrue
,int_hubspot__email_metrics__by_contact_list
is now brought in as a dependency, and ignored otherwise.🚘 Under the Hood 🚘
integration_tests/dbt_project.yml
variables to be global to ensure more effective testing of our seed data.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Was able to reproduce the compilation error when I set
hubspot_contact_list_member_enabled
was set to false inintegration_tests
, and then confirm that adding the new variable config inhubspot_contact_lists
fixed the issue.If you had to summarize this PR in an emoji, which would it be?
🥼