Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Compilation error on the end contact lists model #142

Merged
merged 11 commits into from
May 14, 2024

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented May 10, 2024

PR Overview

This PR will address the following Issue/Feature: [#141]

This PR will result in the following new package version: 0.17.2

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🪲 Bug Fixes 🪛

  • Fixed the fivetran_utils.enabled_vars conditional by adding the hubspot_contact_list_member_enabled variable in hubspot_contact_lists to solve for compilation errors when the contact_list source table is not being used. If hubspot_contact_list_member_enabled is true, int_hubspot__email_metrics__by_contact_list is now brought in as a dependency, and ignored otherwise.

🚘 Under the Hood 🚘

  • Updated the integration_tests/dbt_project.yml variables to be global to ensure more effective testing of our seed data.
  • Updated the maintainer PR template to resemble the most up to date format.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Was able to reproduce the compilation error when I set hubspot_contact_list_member_enabled was set to false in integration_tests, and then confirm that adding the new variable config in hubspot_contact_lists fixed the issue.

If you had to summarize this PR in an emoji, which would it be?

🥼

@fivetran-avinash fivetran-avinash linked an issue May 10, 2024 that may be closed by this pull request
4 tasks
@fivetran-avinash fivetran-avinash self-assigned this May 10, 2024
@fivetran-avinash fivetran-avinash changed the title Bug Fix: Compilation error on the end contact lists model [Bug] Compilation error on the end contact lists model May 10, 2024
@fivetran-avinash fivetran-avinash marked this pull request as ready for review May 13, 2024 16:14
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-avinash LGTM with one small CHANGELOG wording suggestion.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Markiewicz <[email protected]>
@fivetran-avinash fivetran-avinash merged commit 946f459 into main May 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fixing compilation error on hubspot_contact_lists
3 participants