document default LEAD columns #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Feb 29, 2024
packages.yml
Outdated
Comment on lines
2
to
7
| # - package: fivetran/marketo_source | ||
| # version: [">=0.11.0", "<0.12.0"] | ||
| # - local: ../../Marketing/Marketo/dbt_marketo_source | ||
| - git: https:/fivetran/dbt_marketo_source.git | ||
| revision: update/customer360 | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to swap before release
fivetran-catfritz
requested changes
Feb 29, 2024
CHANGELOG.md
Outdated
| [PR #32](https:/fivetran/dbt_marketo/pull/32) and Marketo Source [PR #35](https:/fivetran/dbt_marketo_source/pull/35) include the following updates: | ||
|
|
||
| ## Feature Updates (includes potentially 🚨 breaking changes 🚨) | ||
| - Ensures that `stg_marketo__lead` (and therefore `marketo__leads`) has and documents the below columns, all [standard](https://developers.marketo.com/rest-api/lead-database/fields/list-of-standard-fields/) fields from Marketo. Previously, peristed all fields found in your `LEAD` source table but only _ensured_ that the `id`, `created_at`, `updated_at`, `email`, `first_name`, `last_name`, and `_fivetran_synced` fields were included. If your `LEAD` table contains the following fields, nothing will change for you. If any of the following default columns are missing from your `LEAD` table, `stg_marketo__lead` will create a NULL version with the proper data type: |
There was a problem hiding this comment.
I'm wondering does this bit:
unsubscribed-> aliased asis_unsubscribed(🚨 breaking change 🚨)email_invalid-> aliased asis_email_invalid(🚨 breaking change 🚨)
make this bit not be entirely true?:
If your
LEADtable contains the following fields, nothing will change for you.
Would their columns get renamed?
| @@ -89,7 +89,7 @@ vars: | |||
| marketo__activity_delete_lead_enabled: false # Disable if you do not have the activity_delete_lead table | |||
| ``` | |||
| ## (Optional) Step 5: Additional configurations | |||
| <details><summary>Expand for details</summary> | |||
| <details open><summary>Expand/Collapse details</summary> | |||
There was a problem hiding this comment.
Ohh this is cool!
Co-authored-by: fivetran-catfritz <[email protected]>
fivetran-catfritz
approved these changes
Mar 6, 2024
fivetran-catfritz
added a commit
that referenced
this pull request
Apr 2, 2024
* document default LEAD columns (#32) * changes * docs * changelog * update source package ref * Update CHANGELOG.md Co-authored-by: fivetran-catfritz <[email protected]> * changelog --------- Co-authored-by: fivetran-catfritz <[email protected]> * Bug/databricks syntax (#33) * changes * docs * changelog * update source package ref * Update CHANGELOG.md Co-authored-by: fivetran-catfritz <[email protected]> * changelog * bug/databricks-syntax * update pkg * update cte * remove ignore nulls * updates * updates & regen docs * update yml --------- Co-authored-by: Jamie Rodriguez <[email protected]> * Update packages.yml --------- Co-authored-by: Jamie Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
fivetran/dbt_marketo_source#35
This PR will result in the following new package version:
v0.11.0 -- we are aliasing fields that existed but were not aliased before
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
see hex linked in height
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🍳