Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add postgres tests to circle configs #39

Merged
merged 6 commits into from
Apr 27, 2022
Merged

Conversation

fivetran-reneeli
Copy link
Contributor

Pull Request
Are you a current Fivetran customer?

Internal

What change(s) does this PR introduce?

adding postgres testing since we added it to the transforms package

Did you update the CHANGELOG?

  • Yes
  • []

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)
    adding postgres support

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Thanks @fivetran-reneeli

Feel free to merge this after addressing the one change. However, it would be great if you could hold off releasing these changes as I will be merging #38 most likely tomorrow morning and can include this change in the next release.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Markiewicz <[email protected]>
@fivetran-reneeli fivetran-reneeli merged commit 0e7f8be into main Apr 27, 2022
@fivetran-reneeli fivetran-reneeli deleted the bug/postgres_timestamp branch April 27, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants