Added timezone to column description #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
added
the
documentation
fivetran-joemarkiewicz
requested changes
Jun 13, 2022
There was a problem hiding this comment.
@mvtemple thanks so much for opening this PR to add a clearer description to our source documentation! 🙌
This change looks great and we will for sure want to fold this into the next release of the package! There are a few quick items we should update in addition to the change you listed here before we merge to the main branch and release:
- Apply the same field definition update to the
stg_stripe.ymlfile. - Increase the
dbt_project.ymlandintegration_test/dbt_project.ymlversion to be the appropriately indexed0.6.1version. - Update the CHANGELOG.md to include your contribution and a description of the contribution 🏅.
Thank you again for taking the time to open this PR 😄. Let me know if you have any questions regarding the above requested changes.
|
Hey @mvtemple thanks again for opening this up. I went ahead and cleared away the rest of the changes needed; once our tests pass we'll go ahead and merge to main! |
|
This has been merged with #45 |
|
Thank you Renee!!!
…On Tue, Jun 21, 2022 at 10:42 AM Renee Li ***@***.***> wrote:
This has been merged with #45
<#45>
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https:/notifications/unsubscribe-auth/AT36FYD4JMLQ7TNO2NC6KEDVQHIDPANCNFSM5YURFDLQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Are you a current Fivetran customer?
Ephemeral Tattoos.
What change(s) does this PR introduce?
Add timezone notation to timestamp column. Should replicate for all timestamp columns for clarity.
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
createdfield for balance transactions should explicitly be defined as UTC #43How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.