Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new models and fields #68

Merged
merged 21 commits into from
Oct 18, 2023
Merged

add new models and fields #68

merged 21 commits into from
Oct 18, 2023

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Aug 25, 2023

PR Overview

This PR will address the following Issue/Feature: n/a

This PR will result in the following new package version: v 11

Not breaking, but significant upgrades to our Stripe package for Q3 2023.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

  • Introduction of new models for the transfer and dispute Stripe objects.
  • Additional of new fields

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • [n/a] The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

Confirm that these additions appear in the target schema when run

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • [n/a] README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-reneeli fivetran-reneeli self-assigned this Aug 25, 2023
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli thanks for putting together this PR. I have a few requests for this to be updated. Let me know if you have any questions on my comments below.

Additionally, it seems the README needs to be updated to reflect the new version of the package following this release.

Lastly, it looks like dispute and transfer are not being found when running integration tests. This is likely a result of some of my comments that need to be addressed.
image

CHANGELOG.md Show resolved Hide resolved
models/stg_stripe__transfer.sql Outdated Show resolved Hide resolved
dbt_project.yml Show resolved Hide resolved
integration_tests/dbt_project.yml Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great to me! I do have a few final requests and questions. Would you be able to address those and then regenerate the docs. Once that is complete this will be good to be approved.

macros/livemode_predicate.sql Outdated Show resolved Hide resolved
models/stg_stripe__transfer.sql Outdated Show resolved Hide resolved
models/stg_stripe__dispute.sql Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great to me!

@fivetran-reneeli fivetran-reneeli merged commit d090bb9 into main Oct 18, 2023
1 check passed
@fivetran-reneeli fivetran-reneeli deleted the feature/q3-2023-updates branch October 18, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants