[ci/tools] Add iOS/macOS analysis to catch deprecated code (flutter#5778

)

.cirrus.yml

@@ -336,6 +336,11 @@ task:
  - ./script/tool_runner.sh build-examples --ios
  xcode_analyze_script:
  - ./script/tool_runner.sh xcode-analyze --ios
+ xcode_analyze_deprecation_script:
+ # Ensure we don't accidentally introduce deprecated code.
+ # TODO(stuartmorgan): Update this to a newer version of iOS to get
+ # ahead of upcoming deprecations.
+ - ./script/tool_runner.sh xcode-analyze --ios --ios-min-version=11.0
  native_test_script:
  - ./script/tool_runner.sh native-test --ios --ios-destination "platform=iOS Simulator,name=Flutter-iPhone,OS=latest"
  drive_script:
@@ -355,6 +360,9 @@ task:
  - ./script/tool_runner.sh build-examples --macos
  xcode_analyze_script:
  - ./script/tool_runner.sh xcode-analyze --macos
+ xcode_analyze_deprecation_script:
+ # Ensure we don't accidentally introduce deprecated code.
+ - ./script/tool_runner.sh xcode-analyze --macos --macos-min-version=12.3
  native_test_script:
  - ./script/tool_runner.sh native-test --macos
  drive_script:

packages/google_sign_in/google_sign_in_ios/example/ios/Podfile

@@ -25,6 +25,9 @@ end
 
 require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)
 
+# Suppress warnings from transitive dependencies that cause analysis to fail.
+pod 'AppAuth', :inhibit_warnings => true
+
 flutter_ios_podfile_setup
 
 target 'Runner' do

script/tool/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 - Fixes changelog validation when reverting to a `NEXT` state.
 - Fixes multiplication of `--force` flag when publishing multiple packages.
+- Adds minimum deployment target flags to `xcode-analyze` to allow
+ enforcing deprecation warning handling in advance of actually dropping
+ support for an OS version.
 - Checks for template boilerplate in `readme-check`.
 - `readme-check` now validates example READMEs when present.
 

script/tool/lib/src/xcode_analyze_command.dart

@@ -23,8 +23,20 @@ class XcodeAnalyzeCommand extends PackageLoopingCommand {
  super(packagesDir, processRunner: processRunner, platform: platform) {
  argParser.addFlag(platformIOS, help: 'Analyze iOS');
  argParser.addFlag(platformMacOS, help: 'Analyze macOS');
+ argParser.addOption(_minIOSVersionArg,
+ help: 'Sets the minimum iOS deployment version to use when compiling, '
+ 'overriding the default minimum version. This can be used to find '
+ 'deprecation warnings that will affect the plugin in the future.');
+ argParser.addOption(_minMacOSVersionArg,
+ help:
+ 'Sets the minimum macOS deployment version to use when compiling, '
+ 'overriding the default minimum version. This can be used to find '
+ 'deprecation warnings that will affect the plugin in the future.');
  }
 
+ static const String _minIOSVersionArg = 'ios-min-version';
+ static const String _minMacOSVersionArg = 'macos-min-version';
+
  final Xcode _xcode;
 
  @override
@@ -57,15 +69,24 @@ class XcodeAnalyzeCommand extends PackageLoopingCommand {
  return PackageResult.skip('Not implemented for target platform(s).');
  }
 
+ final String minIOSVersion = getStringArg(_minIOSVersionArg);
+ final String minMacOSVersion = getStringArg(_minMacOSVersionArg);
+
  final List<String> failures = <String>[];
  if (testIOS &&
  !await _analyzePlugin(package, 'iOS', extraFlags: <String>[
  '-destination',
- 'generic/platform=iOS Simulator'
+ 'generic/platform=iOS Simulator',
+ if (minIOSVersion.isNotEmpty)
+ 'IPHONEOS_DEPLOYMENT_TARGET=$minIOSVersion',
  ])) {
  failures.add('iOS');
  }
- if (testMacOS && !await _analyzePlugin(package, 'macOS')) {
+ if (testMacOS &&
+ !await _analyzePlugin(package, 'macOS', extraFlags: <String>[
+ if (minMacOSVersion.isNotEmpty)
+ 'MACOSX_DEPLOYMENT_TARGET=$minMacOSVersion',
+ ])) {
  failures.add('macOS');
  }
 

script/tool/test/xcode_analyze_command_test.dart

@@ -123,6 +123,47 @@ void main() {
  ]));
  });
 
+ test('passes min iOS deployment version when requested', () async {
+ final RepositoryPackage plugin = createFakePlugin('plugin', packagesDir,
+ platformSupport: <String, PlatformDetails>{
+ platformIOS: const PlatformDetails(PlatformSupport.inline)
+ });
+
+ final Directory pluginExampleDirectory = getExampleDir(plugin);
+
+ final List<String> output = await runCapturingPrint(runner,
+ <String>['xcode-analyze', '--ios', '--ios-min-version=14.0']);
+
+ expect(
+ output,
+ containsAllInOrder(<Matcher>[
+ contains('Running for plugin'),
+ contains('plugin/example (iOS) passed analysis.')
+ ]));
+
+ expect(
+ processRunner.recordedCalls,
+ orderedEquals(<ProcessCall>[
+ ProcessCall(
+ 'xcrun',
+ const <String>[
+ 'xcodebuild',
+ 'analyze',
+ '-workspace',
+ 'ios/Runner.xcworkspace',
+ '-scheme',
+ 'Runner',
+ '-configuration',
+ 'Debug',
+ '-destination',
+ 'generic/platform=iOS Simulator',
+ 'IPHONEOS_DEPLOYMENT_TARGET=14.0',
+ 'GCC_TREAT_WARNINGS_AS_ERRORS=YES',
+ ],
+ pluginExampleDirectory.path),
+ ]));
+ });
+
  test('fails if xcrun fails', () async {
  createFakePlugin('plugin', packagesDir,
  platformSupport: <String, PlatformDetails>{
@@ -218,6 +259,41 @@ void main() {
  ]));
  });
 
+ test('passes min macOS deployment version when requested', () async {
+ final RepositoryPackage plugin = createFakePlugin('plugin', packagesDir,
+ platformSupport: <String, PlatformDetails>{
+ platformMacOS: const PlatformDetails(PlatformSupport.inline),
+ });
+
+ final Directory pluginExampleDirectory = getExampleDir(plugin);
+
+ final List<String> output = await runCapturingPrint(runner,
+ <String>['xcode-analyze', '--macos', '--macos-min-version=12.0']);
+
+ expect(output,
+ contains(contains('plugin/example (macOS) passed analysis.')));
+
+ expect(
+ processRunner.recordedCalls,
+ orderedEquals(<ProcessCall>[
+ ProcessCall(
+ 'xcrun',
+ const <String>[
+ 'xcodebuild',
+ 'analyze',
+ '-workspace',
+ 'macos/Runner.xcworkspace',
+ '-scheme',
+ 'Runner',
+ '-configuration',
+ 'Debug',
+ 'MACOSX_DEPLOYMENT_TARGET=12.0',
+ 'GCC_TREAT_WARNINGS_AS_ERRORS=YES',
+ ],
+ pluginExampleDirectory.path),
+ ]));
+ });
+
  test('fails if xcrun fails', () async {
  createFakePlugin('plugin', packagesDir,
  platformSupport: <String, PlatformDetails>{