Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced classmethod decorator with staticmethod if the class variable is not used #140

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Replaced classmethod decorator with staticmethod if the class variable is not used #140

merged 3 commits into from
Mar 6, 2024

Conversation

heuer
Copy link
Contributor

@heuer heuer commented Mar 5, 2024 •
edited by flacjacket
Loading

Fixes #138

Fixes #137

flacjacket
flacjacket approved these changes Mar 6, 2024
View reviewed changes
Copy link
Owner

@flacjacket flacjacket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes!

@flacjacket flacjacket merged commit 6061887 into flacjacket:main Mar 6, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flacjacket flacjacket flacjacket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace @classmethod with @staticmethod? Seat.set_keyboard should accept None
2 participants
@heuer @flacjacket