Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for OutputState #171

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

heuer
Copy link
Contributor

@heuer heuer commented Apr 8, 2024

All changes should be backwards compatible.

* Added OutputState to wlr_types/output.py
* Moved CustomMode from wlr_types/output_management_v1.py to
  wlr_types/output.py
* Added OutputHeadV1State.apply(OutputState) (closes flacjacket#149)
* Fixed OutputHeadV1State.custom_mode setter (closes flacjacket#170)
* Output.test() and Output.commit() accept an optional OutputState
  object

All changes should be backwards compatible.
@heuer
Copy link
Contributor Author

heuer commented Apr 8, 2024

Note to @jwijenbergh and @m-col: I wanted to use the OutputState from the WLR-17 branch, but it missed some functionality, so I came up with my own implementation.

Further differences from the WLR-17 branch: The Output.commit() and .test() methods take an optional OutputState object so the Output.commit_state() and Output.test_state() methods are superfluous.

@heuer heuer mentioned this pull request Apr 8, 2024
@jwijenbergh
Copy link
Contributor

Nice! You may also send a PR into my wlr 0.17 if you want

@heuer
Copy link
Contributor Author

heuer commented Apr 9, 2024

You may also send a PR into my wlr 0.17

How can I do that? Github doesn't allow a fork of your repository because I already have a fork of the main repository

@jwijenbergh
Copy link
Contributor

You may also send a PR into my wlr 0.17

How can I do that? Github doesn't allow a fork of your repository because I already have a fork of the main repository

Add me as a remote, rebase pr on top of the wlr 0.17 branch and then click new pull request in my fork

@flacjacket flacjacket merged commit 230e00b into flacjacket:main Apr 16, 2024
35 checks passed
@heuer heuer deleted the issue_149_outputstate branch April 16, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OutputHeadV1State: Invalid custom_mode setter Add OutputHeadV1State.apply()
3 participants