refactor: split to package/files #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
flavono123
commented
Oct 2, 2023
flavono123
commented
- create model pkg and its components
- model(parrent); <- refine methods for this
- labelkey
- labelvalue
- nodeinfos
- just move for else
most of the code is for model, let's split it more in detail
- unexport - remove infos param. it can be accessed by model - do not return NodeInfos, assign to model directly - unexport model.filteredNodeInfos also
- move nodeInfos things to seperated file
- unexport all
- except for constructor methods
- NewNodeInfos
- With...
- pull up append label value to node infos(but for what?) Signed-off-by: flavono123 <[email protected]>
- since can reference from it self
- function to method of model - remove arg model's field - do not return, update itself
- naming convention: update + field name - describe as comment what it does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.